gabeszm/weclome-banner
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix strict mode template: import helpers and use concat properly

Browse source 
- Import concat, eq, and, not helpers from Ember packages
- Replace inline {{fa-icon}} interpolation with concat helper
- Fix Font Awesome class construction: class={{concat "fas fa-" settings.icon}}
- Import truth-helpers for conditional logic
- Ensures strict mode template compliance

Fixes compile error: "Attempted to resolve a helper in a strict mode template"

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
gabeszm 2025-10-16 17:19:39 +02:00
parent c683bc82a9
commit 6bea82288b
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
javascripts/discourse/components/welcome-banner.gjs
View file

@ -2,6 +2,8 @@ import Component from "@glimmer/component";
import { service } from "@ember/service"; import { service } from "@ember/service";
import { htmlSafe } from "@ember/template"; import { htmlSafe } from "@ember/template";
import { on } from "@ember/modifier"; import { on } from "@ember/modifier";
import { concat } from "@ember/helper";
import { eq, and, not } from "truth-helpers";
import didInsert from "@ember/render-modifiers/modifiers/did-insert"; import didInsert from "@ember/render-modifiers/modifiers/did-insert";
import willDestroy from "@ember/render-modifiers/modifiers/will-destroy"; import willDestroy from "@ember/render-modifiers/modifiers/will-destroy";
import SearchMenu from "discourse/components/search-menu"; import SearchMenu from "discourse/components/search-menu";
@ -71,7 +73,7 @@ export default class WelcomeBanner extends Component {
<a href={{settings.cta_card_1_url}} class="cta-card" aria-label={{settings.cta_card_1_title}}> <a href={{settings.cta_card_1_url}} class="cta-card" aria-label={{settings.cta_card_1_title}}>
<div class="cta-icon"> <div class="cta-icon">
{{#if (eq settings.cta_card_1_icon_type "font_awesome")}} {{#if (eq settings.cta_card_1_icon_type "font_awesome")}}
<i class="fas fa-{{settings.cta_card_1_icon_font_awesome}}"></i> <i class={{concat "fas fa-" settings.cta_card_1_icon_font_awesome}}></i>
{{else}} {{else}}
{{settings.cta_card_1_icon_emoji}} {{settings.cta_card_1_icon_emoji}}
{{/if}} {{/if}}
@ -93,7 +95,7 @@ export default class WelcomeBanner extends Component {
<a href={{settings.cta_card_2_url}} class="cta-card" aria-label={{settings.cta_card_2_title}}> <a href={{settings.cta_card_2_url}} class="cta-card" aria-label={{settings.cta_card_2_title}}>
<div class="cta-icon"> <div class="cta-icon">
{{#if (eq settings.cta_card_2_icon_type "font_awesome")}} {{#if (eq settings.cta_card_2_icon_type "font_awesome")}}
<i class="fas fa-{{settings.cta_card_2_icon_font_awesome}}"></i> <i class={{concat "fas fa-" settings.cta_card_2_icon_font_awesome}}></i>
{{else}} {{else}}
{{settings.cta_card_2_icon_emoji}} {{settings.cta_card_2_icon_emoji}}
{{/if}} {{/if}}
@ -115,7 +117,7 @@ export default class WelcomeBanner extends Component {
<a href={{settings.cta_card_3_url}} class="cta-card" aria-label={{settings.cta_card_3_title}}> <a href={{settings.cta_card_3_url}} class="cta-card" aria-label={{settings.cta_card_3_title}}>
<div class="cta-icon"> <div class="cta-icon">
{{#if (eq settings.cta_card_3_icon_type "font_awesome")}} {{#if (eq settings.cta_card_3_icon_type "font_awesome")}}
<i class="fas fa-{{settings.cta_card_3_icon_font_awesome}}"></i> <i class={{concat "fas fa-" settings.cta_card_3_icon_font_awesome}}></i>
{{else}} {{else}}
{{settings.cta_card_3_icon_emoji}} {{settings.cta_card_3_icon_emoji}}
{{/if}} {{/if}}
@ -137,7 +139,7 @@ export default class WelcomeBanner extends Component {
<a href={{settings.cta_card_4_url}} class="cta-card" aria-label={{settings.cta_card_4_title}}> <a href={{settings.cta_card_4_url}} class="cta-card" aria-label={{settings.cta_card_4_title}}>
<div class="cta-icon"> <div class="cta-icon">
{{#if (eq settings.cta_card_4_icon_type "font_awesome")}} {{#if (eq settings.cta_card_4_icon_type "font_awesome")}}
<i class="fas fa-{{settings.cta_card_4_icon_font_awesome}}"></i> <i class={{concat "fas fa-" settings.cta_card_4_icon_font_awesome}}></i>
{{else}} {{else}}
{{settings.cta_card_4_icon_emoji}} {{settings.cta_card_4_icon_emoji}}
{{/if}} {{/if}}